Repository navigation
gh-153668: extend winarm64 compiler workaround to msvc 14.52 - #162262
Conversation
MSVC 14.52 still triggers the excessive-memory optimizer failure in unicodectype.c. Apply the existing Windows ARM64 workaround to this toolset version.
|
Added the issue link created by the bedevere bot again. @tonghuaroot please do not delete the issue links. They are auto-generated based on the |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
updated the news entry and kept it in build, it now specifies regular release builds. i will keep the generated issue links. i have made the requested changes, please review again. |
|
Thanks @tonghuaroot for the PR, and @chris-eibl for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
Thanks @tonghuaroot for the PR, and @chris-eibl for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
GH-162367 is a backport of this pull request to the 3.14 branch. |
|
GH-162368 is a backport of this pull request to the 3.15 branch. |
|
Thanks @tonghuaroot ❤️ |
|
…Windows ARM64 Release builds (GH-162262) (#162368) * gh-153668: Disable ``unicodectype.c`` optimization in regular Windows ARM64 Release builds due to a compiler bug in MSVC 14.50, 14.51, and 14.52. PGO builds are not affected. --------- (cherry picked from commit 3d248a2) Co-authored-by: tonghuaroot (童话) <tonghuaroot@gmail.com> Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
…Windows ARM64 Release builds (GH-162262) (#162367) * gh-153668: Disable ``unicodectype.c`` optimization in regular Windows ARM64 Release builds due to a compiler bug in MSVC 14.50, 14.51, and 14.52. PGO builds are not affected. --------- (cherry picked from commit 3d248a2) Co-authored-by: tonghuaroot (童话) <tonghuaroot@gmail.com> Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
|
|
msvc 14.52 still triggers the optimizer heap exhaustion reported in gh 153668. this extends the existing windows arm64 workaround to this toolset version.
the windows arm64 release build and the full jit workflow pass with the same runner image.